fix(memory): support Chroma v2 collection endpoints - #1394
Draft
EmersonBraun wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/api/v1collection routes to the current tenant/database-scoped/api/v2routestenant,database,apiKey, and customheadersconfigurationWhy
Current Chroma releases route
/api/v1/*to a deprecation response, while collection operations in v2 require tenant, database, and collection ID path segments. The existing adapter therefore looked healthy under permissive mocks but could not complete real operations against Chroma 1.5.9.Impact
Local Chroma users can keep using only
urlandcollection; the adapter defaults todefault_tenantanddefault_database. Hosted deployments can now provide tenant/database values, anx-chroma-tokenAPI key, and additional headers without changing theVectorMemorycontract.Validation
pnpm --filter @agentskit/memory test— 218 tests passedpnpm --filter @agentskit/memory test:coverage— 91.06% statements overall; Chroma 100% statements/linespnpm --filter @agentskit/memory lintpnpm --filter @agentskit/memory buildpnpm docs:bridge:gatepnpm check:quality-gates— all 29 gates passedpnpm size—@agentskit/memory13.7 KB / 15 KBchromadb/chroma:1.5.9lifecycle: create collection, store, search, and delete passed