fix(hosting): scope gh.local traefik to its own compose project#4703
fix(hosting): scope gh.local traefik to its own compose project#4703mmabrouk wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds identical Docker provider constraints to Traefik service commands across five Compose configuration files (EE GitHub local/production, OSS GitHub local/production, and OSS SSL). Each constraint restricts Traefik's Docker provider discovery to containers labeled with the active Compose project name, defaulting to the respective environment name when ChangesTraefik Docker Provider Project Scoping
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jp-agenta extended the Traefik Docker-provider project constraint to the remaining Files changed in this push:
Already had the constraint (left untouched):
I verified all edited files still parse as YAML. |
Context
Running two stacks on one host breaks the web UI. The gh.local EE stack starts traefik with
--providers.dockerand no constraint, so traefik watches every container on the Docker host, not just its own. When a second compose stack runs on the same machine, both stacks' routers claim the same hostnames. traefik cannot tell them apart, the web service hangs, and the page returns HTTP 000.Changes
Add a Docker provider constraint so each stack's traefik only routes containers from its own compose project.
It reads
COMPOSE_PROJECT_NAMEand falls back toagenta-ee-gh-local, the default project name for this file. A single-stack setup behaves exactly as before.Tests / notes
One-line config change. No application code is affected.