feat: support external CardView submission - #1201
Open
PrinceD96 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for external submission of the CardView component in the Adyen React Native SDK. It adds a showSubmitButton configuration option to hide the native submit button, exposes a submit() method via a CardViewHandle ref, and implements the native bridging logic on both Android and iOS. The review feedback highlights two critical issues: a thread-safety concern in Android's CardComponentManager where UI-bound components are interacted with on a background thread instead of the Main thread, and a potential infinite render loop in React Native's CardView due to onReadyChange being used as a dependency in useEffect.
PrinceD96
marked this pull request as ready for review
July 26, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
card.showSubmitButtonfor iOS and Android while preserving the existing defaultCardViewHandle.submit(): voidfor merchant-owned CTAs, matching Adyen Web's imperative submit patternhide(false)Testing
yarn typecheckyarn test --runInBand(27 suites, 272 tests)testDebugUnitTest(96 tests)ktlintApplePayConfiguration.ts(and locally generated Android test reports match its broad glob)No simulator or emulator was used.
Closes #1200