Skip to content

fix: replace innerHTML with textContent and fix NotificationDropdown spread order #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: replace innerHTML with textContent and fix NotificationDropdown spread order #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0155c
fix: 3 bare excepts should catch ValueError instead of BaseException
Jul 19, 2026
67d49de
fix: replace innerHTML with textContent and fix NotificationDropdown …
Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/extract_rankings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def extract_rankings():
# Check if Rank is numeric, if not skip (it might be a comment row)
try:
rank = int(rank_val)
except:
except ValueError:
continue

item = {
Expand Down
4 changes: 2 additions & 2 deletions scripts/extract_rankings_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def safe_float(val):
if match:
try:
return float(match.group(1))
except:
except ValueError:
pass
return 0.0

Expand Down Expand Up @@ -96,7 +96,7 @@ def extract_rankings():

try:
rank = int(rank_val)
except:
except ValueError:
continue

if i == 0:
Expand Down
6 changes: 3 additions & 3 deletions src/app/wiki/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@ export default function WikiPage() {

const button = document.createElement('button');
button.className = 'absolute right-3 top-3 px-2 py-1 text-xs font-semibold bg-zinc-900/80 text-zinc-300 rounded border border-white/10 opacity-0 group-hover:opacity-100 hover:bg-zinc-800 hover:text-white transition-all duration-200 shadow-md cursor-pointer backdrop-blur-sm';
button.innerHTML = 'Copy';
button.textContent = 'Copy';
button.type = 'button';

button.addEventListener('click', async () => {
const codeText = pre.textContent || '';
try {
await navigator.clipboard.writeText(codeText);
button.innerHTML = 'Copied!';
button.textContent = 'Copied!';
button.className = 'absolute right-3 top-3 px-2 py-1 text-xs font-semibold bg-emerald-600 text-white rounded border border-emerald-500 transition-all duration-200 shadow-md';
setTimeout(() => {
button.innerHTML = 'Copy';
button.textContent = 'Copy';
button.className = 'absolute right-3 top-3 px-2 py-1 text-xs font-semibold bg-zinc-900/80 text-zinc-300 rounded border border-white/10 opacity-0 group-hover:opacity-100 hover:bg-zinc-800 hover:text-white transition-all duration-200 shadow-md cursor-pointer backdrop-blur-sm';
}, 2000);
} catch (err) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NotificationDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function NotificationDropdown() {

const unsubscribe = onSnapshot(q,
(snapshot) => {
setNotifications(snapshot.docs.map(doc => ({ id: doc.id, ...doc.data() } as Notification)));
setNotifications(snapshot.docs.map(doc => ({ ...doc.data(), id: doc.id } as Notification)));
},
(error) => {
console.error("Notification subscription error:", error);
Expand Down
Loading