-
Notifications
You must be signed in to change notification settings - Fork 57
feat: zh-cn-localization #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CaesinEachonson
wants to merge
21
commits into
Adeptus-Dominus:main
Choose a base branch
from
CaesinEachonson:feat/zh-cn-localization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: zh-cn-localization #1431
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
69aa9f0
Feat: Added a language option in setting menu. Added a little test tr…
CaesinEachonson 1eb8568
Fix: Gobo format check
CaesinEachonson ed38ba3
Feature: extract hardcoded strings in chapter creation session to en.…
CaesinEachonson b90fbdb
fix(localization): address review comments (lookups, fonts, CM_get_fo…
CaesinEachonson fadab29
Fix: address review comments
CaesinEachonson ca0a8d5
Fix: crash on switching language
CaesinEachonson 9af5a62
Merge feat/localization-base into feat/zh-chapter-creation
CaesinEachonson 3489afd
chore(l10n): refine translation strings
CaesinEachonson 501a658
chore(l10n): refine translation strings
CaesinEachonson 72c45be
fix: potential crash on opening squad view
CaesinEachonson d453c7b
merge: solve conflicts with main branch
CaesinEachonson 1b87c88
fix: address review comments
CaesinEachonson 8b11e6d
fix: address review comment
CaesinEachonson b93317a
fix: address review comment
CaesinEachonson 4d0f5a3
fix: address review comment
CaesinEachonson df7585a
fix: address review comment
CaesinEachonson 3fb4445
fix: address review comment
CaesinEachonson 0899bec
address review comment
CaesinEachonson 4d4d5ae
fix: address review comment
CaesinEachonson 96a3eb1
fix: address review comment
CaesinEachonson 7afe752
fix: address review comment
CaesinEachonson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: In Chinese (CJK) mode the tooltip/role-name popup now goes through cjk_font() for both the bold title (fnt_40k_14b) and the regular body (fnt_40k_14). LocalizationManager.get_font() caches its fallback font by point size only (
string(_size)), and both of these fonts are size 14, so they resolve to the same cached CJK font and the bold/regular visual distinction disappears (and fnt_40k_14i would collapse into the same entry too). This makes the bold title text render with body weight in the localized UI. Consider including the style/typeface in the cache key (or explicitly documenting that CJK fallback can't preserve weight), so same-size fonts with different styles don't silently share one glyph set.Prompt for AI agents