Skip to content

feat: MK5 shading; fix redundant MK3 trim - #1383

Merged
EttyKitty merged 2 commits into
Adeptus-Dominus:mainfrom
UXLZ:mk5-shading
Jul 24, 2026
Merged

feat: MK5 shading; fix redundant MK3 trim#1383
EttyKitty merged 2 commits into
Adeptus-Dominus:mainfrom
UXLZ:mk5-shading

Conversation

@UXLZ

@UXLZ UXLZ commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

MK5 Complex + Backpack
Redundant trim removed (MK3 given MK4 trim, it gained one variant, maybe it's not a lore accurate one idk but they were otherwise the same.)

Tested visually.


Summary by cubic

Adds shaded MK5 Complex armour and backpack sprites and wires them into the modular renderer for better depth and lighting. Also cleans up trim selection and moves MK5 setup to culture visuals.

  • New Features

    • Added spr_mk5_complex_shadow and spr_mk5_complex_backpack_shadow and hooked them into scr_culture_visuals for “MK5 Heresy”.
    • Updated MK5 Complex and backpack base sprites.
  • Refactors

    • MK5 Heresy armour/backpack now selected via scr_culture_visuals instead of scr_ComplexSet.
    • MK3 now uses MK4 right trim with shadows and flip in scr_culture_visuals; redundant MK3 trim removed.

Written for commit e38e2b7. Summary will update on new commits.

Review in cubic

MK5 Complex + Backpack
Redundant trim removed (MK3 given MK4 trim, gained one variant, maybe it's not lore accurate idk.)

Tested visually.
@github-actions github-actions Bot added Area: Sprites Changes to sprites/images or their under-the-hood functionality Size: Medium Type: Feature Adds something new labels Jul 24, 2026
Comment thread scripts/scr_culture_visuals/scr_culture_visuals.gml Outdated
@kilo-code-bot

kilo-code-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are.

Files Reviewed (1 file)
  • scripts/scr_culture_visuals/scr_culture_visuals.gml — previous critical typo ("MK5 heresy""MK5 Heresy") has been resolved; no new issues found in incremental diff
Previous Review Summary (commit 511e6ad)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 511e6ad)

Verdict: 1 Critical Issue Found | Recommendation: Address before merge

Overview

Severity Count
🚨 critical 1
⚠️ warning 0
💡 suggestion 0
🤏 nitpick 0
Issue Details (click to expand)
File Line Roast
scripts/scr_culture_visuals/scr_culture_visuals.gml 2052 armours: ["MK5 heresy"] — lowercase 'h' typo causes the backpack shadow sprite to never render for MK5 Heresy units; array_contains is case-sensitive in GML

🏆 Best part: The sprite plumbing work (shadows, struct structure, muscling armours out of scr_ComplexSet.gml into culture visuals) is genuinely well done — the architecture here is clean.

💀 Worst part: The "MK5 heresy" typo at line 2052 means the MK5 Heresy backpack sprite was technically added AND will never display. That is the software equivalent of buying a gift and throwing it in a woodchipper before giving it. The shadow asset files exist, the registry entry exists, but the name check silently rejects them at runtime.

📊 Overall: Like a race car with no fuel line — the engine's there, the parts are there, but it's going nowhere fast.

Files Reviewed (4 files)
  • scripts/scr_culture_visuals/scr_culture_visuals.gml — 1 critical issue (backpack armours string typo)
  • scripts/scr_ComplexSet/scr_ComplexSet.gml — no issues (clean removal of redundant MK5 Heresy armour/backpack entries)
  • ChapterMaster.yyp — no issues (new resource registrations are correct)
  • sprites/spr_mk5_complex*.yy / sprites/spr_mk5_complex_backpack*.yy — no issues (YY metadata correctly updated, image layer IDs consistent)

Fix these issues in Kilo Cloud


Reviewed by step-3.7-flash · Input: 38.8K · Output: 2.3K · Cached: 244.4K

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread scripts/scr_culture_visuals/scr_culture_visuals.gml Outdated
Co-authored-by: kilo-code-bot[bot] <240665456+kilo-code-bot[bot]@users.noreply.github.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic

@EttyKitty EttyKitty changed the title feat: Sprite shading feat: MK5 shading; fix redundant MK3 trim Jul 24, 2026
@EttyKitty
EttyKitty merged commit bdbc72b into Adeptus-Dominus:main Jul 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Sprites Changes to sprites/images or their under-the-hood functionality Size: Medium Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants