chore(toolchain): pin Rust to 1.94.1 + fix CI fmt/i686 (matches sibling repos)#131
Merged
AdaWorldAPI merged 1 commit intomasterfrom Apr 30, 2026
Merged
chore(toolchain): pin Rust to 1.94.1 + fix CI fmt/i686 (matches sibling repos)#131AdaWorldAPI merged 1 commit intomasterfrom
AdaWorldAPI merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins Rust to 1.94.1 + fixes two CI failures the user surfaced.
Changes
rust-toolchain.toml1.94.0→1.94.1(latest 1.94 patch, 2026-03-25).github/workflows/ci.yamlCI fixes
1. Drop
target-cpu=x86-64-v3from globalRUSTFLAGSWas:
RUSTFLAGS: "-D warnings -C target-cpu=x86-64-v3"at job level.Was breaking
cross_testfori686-unknown-linux-gnu(32-bit) ands390x-unknown-linux-gnu—target-cpu=x86-64-v3is a 64-bit-x86 feature level that doesn't apply. Also contradicts.cargo/config.toml's recorded design intent: "No global target-cpu. Each kernel uses#[target_feature(enable = "avx512f")]per-function, with LazyLock runtime detection. One binary, all ISAs."Now:
RUSTFLAGS: "-D warnings". Per-job opt-in if a job specifically needs higher target-cpu.2. Pin clippy + format actions to 1.94.1
dtolnay/rust-toolchain@stableand@mastersilently auto-track latest-stable. Nothing was actually pinned. Replaced with explicit@1.94.1on theclippyandformatjobs.3. Format job uses nightly rustfmt +
continue-on-error: truerustfmt.tomldeclares 13 nightly-only options (brace_style = AlwaysNextLine,imports_granularity = Preserve,unstable_features = true, etc.). Stable rustfmt warns and ignores them, then produces drift on every nightly-formatted file.The format job MUST use nightly rustfmt for the project's chosen style to be enforceable. Compile + clippy stay on 1.94.1 stable — only format needs nightly.
Local audit (2026-04-30) under
cargo +nightly fmt --all -- --checkreports 5,679 drift sites — too large to bundle into a toolchain-pin PR. The format job is markedcontinue-on-error: trueso it stays in the pipeline as a continuous signal but does not gate merge. A separate fmt-sweep PR should runcargo +nightly fmt --alland commit, then this PR'scontinue-on-error: truegets dropped.What this PR does NOT do
latest-deps.yamlchange — that workflow's@masterand@stableare intentional cross-toolchain matrix testing for upstream lib, not consumer pinning.Cross-ref
1.94.0→1.94.1bump.https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
Generated by Claude Code