NanoVDB: install six missing public headers - #2311
Merged
kmuseth merged 1 commit intoSep 3, 2026
Merged
Conversation
cuda/Buffer.h, cuda/PinnedResource.h, math/Proximity.h, tools/cuda/MeshToGrid.cuh, util/MaskPrefixSum.h and util/cuda/Rasterization.cuh are in the source tree but absent from the install lists, so the installed tree contained headers referencing files it did not ship: 42 installed headers reach cuda/Buffer.h and two reach util/MaskPrefixSum.h. In-tree builds compile against the source directory, where every header exists, so the omissions stay invisible until the headers are installed. Compiling a translation unit that includes each installed header against an installed prefix goes from 40/88 to 83/94, with the 44 missing-file errors eliminated. Signed-off-by: Efty Sifakis <esifakis@nvidia.com>
sifakis
marked this pull request as ready for review
September 3, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six headers live in the source tree but are absent from the
set(NANOVDB_INCLUDE_*_FILES)liststhat
install(FILES ...)copies, somake installproduces a tree containing headers thatreference files it did not ship:
cuda/Buffer.hNANOVDB_INCLUDE_CUDA_FILEScuda/PinnedResource.hNANOVDB_INCLUDE_CUDA_FILESmath/Proximity.hNANOVDB_INCLUDE_MATH_FILEStools/cuda/MeshToGrid.cuhNANOVDB_INCLUDE_TOOLS_CUDA_FILESutil/MaskPrefixSum.hNANOVDB_INCLUDE_UTIL_FILESutil/cuda/Rasterization.cuhNANOVDB_INCLUDE_UTIL_CUDA_FILESTwo of them are reached by installed headers, which makes this a hard failure rather than a
missing convenience — 42 installed headers transitively include
cuda/Buffer.hand two includeutil/MaskPrefixSum.h:tools/cuda/MeshToGrid.cuhis not reached by an installed header, so it produces no error — it issimply unavailable from an installed NanoVDB.
math/Proximity.handutil/cuda/Rasterization.cuhare its transitive dependencies, so all three are needed for it to be usable.
In-tree builds compile against the source directory, where every header exists, so none of this is
visible until the headers are installed.
This is the same class of drift fixed by #2117 ("Fix missing nanovdb install files"), which added
eight entries in one sweep — including
tools/cuda/DilateGrid.cuh, which had been in the treesince 2025-09-04 and was installed only from 2025-10-22.