Fix bug: index error in checkNeighbours - #2302
Closed
schneider007 wants to merge 1 commit into
Closed
Conversation
|
|
Author
|
/bot add-label bug-fix |
kmuseth
requested changes
Aug 27, 2026
kmuseth
left a comment
kmuseth
left a comment
Contributor
There was a problem hiding this comment.
wow - this looks like a legit bug fix! Fascinating that it has been present in code that has been used for many years in production
One request for change: Please add a change note in pendingchanges/openvdb_tools.txt
| if (mask[0] && Compare::check(data[pos + NodeT::DIM * NodeT::DIM])) return true; | ||
| // i+1, j, k-1 | ||
| if (mask[6] && Compare::check(data[pos + NodeT::DIM * NodeT::DIM])) return true; | ||
| if (mask[6] && Compare::check(data[pos + NodeT::DIM * NodeT::DIM - 1])) return true; |
Contributor
There was a problem hiding this comment.
please resolve the DCO issue - otherwise I'll have to create a PR with your fix
Contributor
|
@schneider007 - I'm happy to resolve the DCO issue by creating a new PR with your fix and the change notes. I can also credit the fix to you (in the change notes) but to do so I need your full name. |
Author
|
My name is hexuejun. |
Contributor
|
This PR is now replace by #2306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown in the title