Skip to content

Created demo modules for testing purposes. Jacoco report switched to …#86

Open
miroslavpojer wants to merge 15 commits into
masterfrom
chore/upddate-to-latest-jacoco-report-gh-action
Open

Created demo modules for testing purposes. Jacoco report switched to …#86
miroslavpojer wants to merge 15 commits into
masterfrom
chore/upddate-to-latest-jacoco-report-gh-action

Conversation

@miroslavpojer
Copy link
Copy Markdown
Collaborator

@miroslavpojer miroslavpojer commented May 17, 2026

Update JaCoCo report GitHub Action and add Python setup

Summary

This PR upgrades the MoranaApps/jacoco-report action to its latest pinned commit and adds a required Python setup step to the JaCoCo CI workflow. No library source or test code is changed.


Changes

.github/workflows/jacoco_report.yml

  • Added Setup Python step (actions/setup-python@a309ff8..., Python 3.14) before the database setup — required by the newer jacoco-report action version.
  • Bumped MoranaApps/jacoco-report action pin from 54bfe2852a5f9c.

Release Notes

  • Upgraded MoranaApps/jacoco-report action to latest stable commit (52a5f9c) for improved coverage reporting in PR comments.
  • Added Python 3.14 setup step to the JaCoCo workflow, required as a dependency of the updated action.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to enhance code quality assurance.
    • Increased code coverage threshold for modified files to 60% to ensure higher testing standards.
    • Updated testing infrastructure dependencies and configuration.

Review Change Stack

Closes #88

@miroslavpojer miroslavpojer self-assigned this May 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Walkthrough

The JaCoCo workflow sets job-level GitHub permissions, raises coverage-per-changed-file to 60.0, adds a pinned actions/setup-python step installing Python 3.14, and updates/pins the MoranaApps/jacoco-report action while replacing its input schema (new thresholds, comment-level: 'full', skip-unchanged: true).

Changes

JaCoCo Workflow Updates

Layer / File(s) Summary
Permissions and coverage threshold
.github/workflows/jacoco_report.yml
Adds job-level permissions (contents: read, issues: write, pull-requests: read) and updates coverage-per-changed-file from 0.0 to 60.0.
Python setup and jacoco-report action update
.github/workflows/jacoco_report.yml
Adds a Setup Python step using actions/setup-python pinned to a commit to install Python 3.14. Updates the MoranaApps/jacoco-report action reference and replaces legacy inputs with global-thresholds, report-thresholds-default, comment-level: 'full', and skip-unchanged: true.

Sequence Diagram(s)

sequenceDiagram
  participant BuildJob as Build Job
  participant SetupPython as actions/setup-python@v4
  participant JacocoReport as MoranaApps/jacoco-report

  Build Job->>SetupPython: install Python 3.14
  Build Job->>JacocoReport: invoke with pinned ref and new inputs (global-thresholds, report-thresholds-default, comment-level:'full', skip-unchanged:true)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • AbsaOSS/balta#73: Modifies the same jacoco_report workflow and jacoco-report action inputs.
  • AbsaOSS/balta#71: Also updates jacoco_report workflow coverage threshold and jacoco-report configuration.

Suggested reviewers

  • salamonpavel
  • tmikula-dev
  • benedeki
  • lsulak

Poem

🐇 I hopped through YAML, tidy and bright,
Installed Python 3.14 overnight,
Thresholds raised, reports pinned with care,
JaCoCo sings its coverage flair,
A tiny hop — workflow done right.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is truncated and vague; it mentions 'demo modules' which isn't reflected in the changeset, and 'Jacoco report switched to...' is incomplete. Complete and clarify the title to accurately describe the main changes: e.g., 'Update JaCoCo report action and add Python setup step' or 'Upgrade MoranaApps/jacoco-report action and configure Python environment'.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description includes an Overview section (Summary), Release Notes with specific upgrade details, and a Related section (Closes #88), matching the required template structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upddate-to-latest-jacoco-report-gh-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AbsaOSS AbsaOSS deleted a comment from github-actions Bot May 17, 2026
miroslavpojer and others added 7 commits May 17, 2026 21:06
…, and technical debt

- Created `operative_task.yml` for general operational and management tasks.
- Introduced `pointer.yml` to track external work across repositories.
- Added `spike_task.yml` for research and investigation tasks.
- Implemented `technical_debt.yml` to document and address technical debt items.

docs: Add Copilot instructions and review rules

- Created `copilot-instructions.md` detailing coding guidelines, output discipline, and testing practices.
- Added `copilot-review-rules.md` to define review behavior and commenting rules.

chore: Configure Dependabot and GitHub workflows

- Added `dependabot.yml` for automated dependency updates.
- Created various workflows for issue assignment, build, release drafting, and publishing.
- Implemented checks for release notes presence and JaCoCo code coverage.

test: Add filename check workflow

- Introduced `test_filenames_check.yml` to enforce naming conventions for test files.
@miroslavpojer miroslavpojer marked this pull request as ready for review May 18, 2026 08:11
Comment thread .github/workflows/jacoco_report.yml Outdated
- name: Check coverage thresholds and add reports in PR comments
id: jacoco
uses: MoranaApps/jacoco-report@54bfe284d1119dc917dddba80517c54c5bcf3627
uses: MoranaApps/jacoco-report@52a5f9c278aaf61700c9975e61a0853875c9d156
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in the comment, what version it is. E.g.
` uses: MoranaApps/jacoco-report@52a5f9c #v3.14

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed it, but when updated by dependabot the comment will be not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize JaCoCo coverage thresholds and document CI workflow configuration

2 participants