admin and candidate prefinal commit by AbdulPIO · Pull Request #2 · AbdulPIO/OTPCaseStudy

AbdulPIO · 2025-07-22T06:53:53Z

No description provided.

avishekdr · 2025-07-23T06:29:54Z

        console.log('Candidates loaded: ');

-        this.candidates = [...attended, ...notAttended];
+        this.candidates = [...(attended || []), ...(notAttended || [])];


Suggested change

this.candidates = [...(attended || []), ...(notAttended || [])];

this.candidates = attended.concat(notAttented);

shubhangi-pio · 2025-07-29T10:49:28Z

+describe('AppComponent', () => {
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      imports: [AppComponent],


delete this file as there is no use as of now

shubhangi-pio · 2025-07-29T10:53:31Z

      next: (count) => this.activeExams = count,
-      error: (err) => console.error(err)
+      error: (err) => {
+        console.error(err)


remove console

shubhangi-pio · 2025-07-29T10:54:13Z

      next: (count) => this.totalCandidates = count,
-      error: (err) => console.error(err)
+      error: (err) => {
+        console.error(err);


remove console

shubhangi-pio · 2025-07-29T11:02:01Z

-      error: () => {
-        this.snackBar.open('Failed to load completed exams.', '', { duration: 5000 });
+      error: (err) => {
+        this.snackBar.open(err?.error?.message || 'Failed to load completed exams.', '', { duration: 5000 });


{ } should be use if there are multiple linse, on above only single line present so use instead error: (err) => this.snackBar.open(err?.error?.message || 'Failed to load completed exams.', '', { duration: 5000 });

shubhangi-pio · 2025-07-29T11:11:06Z

+      position: relative;
+    }
+    .submit-btn mat-spinner {
+      margin: 0 !important;


Try to avoid important here

shubhangi-pio · 2025-07-29T11:11:44Z

+    }
+    .submit-btn mat-spinner {
+      margin: 0 !important;
+      position: static !important;


shubhangi-pio · 2025-07-29T11:14:49Z

+    this.examForm.get('title')?.valueChanges.subscribe((title: string) => {
+      if (title && title.trim().length > 0) {
+        const generatedKey = this.generateExamKey(title);
+        this.examForm.get('key')?.setValue(generatedKey, { emitEvent: false });


this.examForm.get('key')?.setValue(this.generateExamKey(title), { emitEvent: false });

shubhangi-pio · 2025-07-29T11:16:34Z

      },
-      error: () => {
-        this.snackBar.open('Failed to load categories', 'Close', {
+      error: (err) => {


{ } remove , seems there is single line

shubhangi-pio · 2025-07-29T11:17:37Z

        })),
      };

+      console.log(examPayload)


remove console log

shubhangi-pio · 2025-07-29T11:28:47Z

-        return errorMessages[errorKey];
-      }
-    }
+    if (control?.hasError('required')) return 'This field is required';


From Line 344 to 354, replaced with below one as repeated if (control?.hasError(...)) checks
const errors = control.errors;
if (errors['required']) return 'This field is required';
if (errors['min']) return Minimum value is ${errors['min'].min};
if (errors['max']) return Maximum value is ${errors['max'].max};
if (errors['minlength']) return Minimum length is ${errors['minlength'].requiredLength};
if (errors['maxlength']) return Maximum length is ${errors['maxlength'].requiredLength};
if (errors['pattern']) return 'Must be exactly 10 alphanumeric characters';

shubhangi-pio · 2025-07-29T11:29:23Z

 .upload-button mat-spinner {
-  width: 20px;
-  height: 20px;
+  margin: 0 !important;


try to avoid !important

shubhangi-pio · 2025-07-29T11:34:06Z

+  font-weight: 700;
+  border-radius: 8px;
+  box-shadow: 0 2px 8px rgba(59, 24, 119, 0.08);
+  background: #3b1877 !important;


try to avoid !important in this file

shubhangi-pio · 2025-07-29T11:37:22Z

+    const token = this.route.snapshot.queryParamMap.get('token');
+    if (token) {
+      this.http.get(`${environment.apiBaseUrl}/auth/verify-email?token=${token}`).subscribe({
+        next: (res: any) => {


give proper type here instead of any

shubhangi-pio · 2025-07-29T11:38:22Z

+    this.router.navigate(['/landing']);
+  }
+
+  resendVerificationLink() {


if this function not in use then remove it

shubhangi-pio · 2025-07-29T11:39:36Z

+  padding: 12px 36px;
+  margin-bottom: 18px;
+  font-weight: 600;
+  background: #7c4dff !important;


try to avoid !important in file

shubhangi-pio · 2025-07-29T11:41:13Z

+.logo {
+  font-size: 80px;
+  color: #3b1877;
+  background: none !important;


try to avoid !important in file

shubhangi-pio · 2025-07-29T11:41:59Z

+        this.loading = false;
+        console.log(this.registrationForm.value);
+        const errorMessage = err?.error?.message || 'Registration failed.';
+        console.log(errorMessage);


remove console from here

shubhangi-pio · 2025-07-29T11:42:16Z

+    this.loading = true;
+    this.candidateRegService.register(this.registrationForm.value).subscribe({
+      next: () => {
+        console.log(this.registrationForm.value);


remove console from here

shubhangi-pio · 2025-07-29T11:43:40Z

+    const email = this.registrationForm.get('email')?.value;
+    if (email) {
+      this.candidateRegService.resendVerification(email).subscribe({
+        next: () => {


remove { } around single line

shubhangi-pio · 2025-07-29T11:43:47Z

+        next: () => {
+          this.snackBar.open('A new verification link has been sent to your email.', 'OK', { duration: 5000 });
+        },
+        error: (err) => {


remove { } around single line

shubhangi-pio · 2025-07-29T11:53:21Z

+    }
+  }
+
+  goToLanding() {


remove this function

shubhangi-pio · 2025-07-29T11:57:34Z

+          >
+            {{ loading ? 'Registering...' : 'Register' }}
+          </button>
+          <button 


From Line 100 to 107 replace with below one, Use routerLink if navigation is static and router.navigate() if navigation needs to be conditional
mat-raised-button
type="button"
class="go-home-btn"
[routerLink] = "['/landing']"
>
Go to Homepage

shubhangi-pio · 2025-07-29T12:04:27Z

+  getStatus(index: number): 'not-seen' | 'seen-not-answered' | 'answered' | 'review' {
+    const q = this.questions[index];
+    if (!q) return 'not-seen';
+    if (this.answers[q.id]?.answer) return 'answered';


const answer = this.answers[q.id];
if (answer?.answer) return 'answered';

shubhangi-pio · 2025-07-29T12:05:27Z

+    const q = this.questions[index];
+    if (!q) return 'not-seen';
+    if (this.answers[q.id]?.answer) return 'answered';
+    if (this.answers[q.id]?.markedForReview) return 'review';


if (answer?.markedForReview) return 'review';

shubhangi-pio · 2025-07-29T12:11:49Z

+    return this.http.post<any>(`${environment.apiBaseUrl}/candidate`, candidate).pipe(
+      tap((res) => {
+        const token = res?.data?.jwtToken || res?.data || res?.jwtToken || res;
+        if (token) {


Instead of if use : token && localStorage.setItem('jwt_token', token);

shubhangi-pio · 2025-07-29T12:12:40Z

+  // Get candidates by exam ID and status
+  getCandidatesByExamAndStatus(examId: number, status: string): Observable<Candidate[]> {
+    const url = `${this.apiUrl}/exam/${examId}/candidate?candidateStatus=${status}`;
+    return this.http.get<any>(url).pipe(


use proper type here instead of any

shubhangi-pio · 2025-07-29T12:13:58Z

remove any data types within file and use proper types

shubhangi-pio

@AbdulPIO Work on changes

avishekdr · 2025-07-31T05:04:30Z

@@ -88,10 +88,10 @@ export class UploadQuestionsComponent {
        this.uploading = false;
        let errorMsg = 'Failed to upload question. Please try again';
        if (


not required to check this condition, you can directly write let message = errorResponse?.error?.message || 'Failed to upload question. Please try again';

avishekdr · 2025-07-31T05:05:05Z

+      next: (res) => {
+        this.loading = false;
+        // Save response data to sessionStorage for exam window
+        if (res && res.data) {


Suggested change

if (res && res.data) {

if (res?.data) {

avishekdr · 2025-07-31T05:06:34Z

+  ngOnInit(): void {
+    const token = this.route.snapshot.queryParamMap.get('token');
+    if (token) {
+      this.http.get(`${environment.apiBaseUrl}/auth/verify-email?token=${token}`).subscribe({


why writing API call in component, define the API calls in a function in service & use that function in component for clean code

avishekdr · 2025-07-31T05:12:14Z

+          this.examService.saveExamSessionData(sessionData);
+
+          this.answers = {};
+


REMOVE EXTRA BLANK LINES FROM FILE

avishekdr · 2025-07-31T05:13:31Z

+      const examData = this.examService.getExamDataFromSession();
+      examData.timeLeft = this.timeLeft;
+      this.examService.saveExamDataToSession(examData);
+      if (this.timeLeft === 15 * 60) {


15*60 these type of values are called magic numbers. store this in a const variable and call the variable rather than writing directly to follow a standard. check this in whole file

avishekdr · 2025-07-31T05:16:12Z

the standard way to define a interceptor file name is NAME.interceptor.ts

avishekdr · 2025-07-31T05:16:59Z

+  resendVerification(email: string): Observable<any> {
+    return this.http.post<any>(
+      `${environment.apiBaseUrl}/auth/send-verification-link?email=${encodeURIComponent(email)}`,
+      {}


Suggested change

{}

null

this sounds better

avishekdr · 2025-07-31T05:18:09Z

+
+
+  logout() {
+    localStorage.removeItem('jwt_token');


Suggested change

localStorage.removeItem('jwt_token');

localStorage.clear();

this will ensure to remove all items from local storage. also check if anything is to be removed from session storage or not

avishekdr · 2025-07-31T05:19:21Z

+  }
+
+  logout() {
+    localStorage.removeItem('jwt_token');


I noticed another logout() function above, why not create 1 single logout() function and use everywhere.

avishekdr

@AbdulPIO look after the comments

admin and candidate prefinal commit

3986042

AbdulPIO requested a review from avishekdr July 22, 2025 06:53

avishekdr reviewed Jul 23, 2025

View reviewed changes

AbdulPIO requested a review from shubhangi-pio July 29, 2025 10:14

shubhangi-pio reviewed Jul 29, 2025

View reviewed changes

shubhangi-pio requested changes Jul 29, 2025

View reviewed changes

avishekdr reviewed Jul 31, 2025

View reviewed changes

avishekdr requested changes Jul 31, 2025

View reviewed changes

	this.candidates = [...(attended \|\| []), ...(notAttended \|\| [])];
	this.candidates = attended.concat(notAttented);

		this.examService.saveExamSessionData(sessionData);

		this.answers = {};

Conversation

AbdulPIO commented Jul 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubhangi-pio Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubhangi-pio left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avishekdr Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubhangi-pio Jul 29, 2025 •

edited

Loading

avishekdr Jul 31, 2025 •

edited

Loading