ci: harden master with CODEOWNERS and unconditional lint-workflows trigger#10
Merged
Merged
Conversation
Lock .github/workflows/ and .github/scripts/ behind admin review. Combined with require_code_owner_review=true in the ruleset, this prevents any non-admin push or PR merge from quietly modifying release workflows or lint scripts.
Drop paths filter from push trigger. Required-status-checks ruleset expects the lint to run on every push to master; with the old paths filter, pushes that didn't touch .github/workflows or the lint script left the check in "expected" state forever (GH013 push rejection observed today on a CODEOWNERS commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits land together so the new lint trigger satisfies the ruleset's required-status-checks rule on master.
Pushing these directly to master got rejected (GH013) because the pre-existing paths-filter on the lint workflow meant the CODEOWNERS commit alone never triggered a lint run, leaving the required check in 'expected' state forever.