fix: require double tildes for strikethrough formatting - #18
Merged
Conversation
goldmark's default GFM strikethrough parser accepts both single (~) and double (~~) tildes. Single tildes caused false positives. Replaces the bundled GFM extension with individual extensions plus a custom parser that requires minimum 2 tildes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~text~and~~text~~, causing false positives with single tildesextension.GFMwith individual extensions plus a custom strikethrough parser that requires minimum 2 tildesTest plan
go build ./...passesgo test ./...passes~~text~~still renders as strikethrough~text~now passes through unchanged