feat(signaling): input validation hardening on all gRPC endpoints - #211
Open
courtnaejames1 wants to merge 3 commits into
Open
feat(signaling): input validation hardening on all gRPC endpoints#211courtnaejames1 wants to merge 3 commits into
courtnaejames1 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a dedicated validate.go file to the signaling package that centralises all input validation logic. Inline checks scattered across grpc.go are replaced with single validator calls at the top of each handler. Validation rules are now enforced consistently on every inbound RPC call, including those made directly via grpcurl or the Go test client, not just through the Qt UI.
Changes
New file — backend/internal/signaling/validate.go
New file — backend/internal/signaling/validate_test.go
Modified — backend/internal/signaling/grpc.go
Modified — backend/internal/signaling/grpc_test.go
Rules enforced
Testing
All existing tests pass.
Run:
cd backend && make test-intergrationCloses #210