Remove redundant scan triggered on every menu popover open - #6
Open
AadhilFarhan wants to merge 1 commit into
Open
Remove redundant scan triggered on every menu popover open#6AadhilFarhan wants to merge 1 commit into
AadhilFarhan wants to merge 1 commit into
Conversation
MenuContent's .task { await model.refresh() } duplicated AppModel's
already-running 3s poll loop (started immediately in init(), before
any menu has ever been opened), so every click on the menu-bar icon
spawned an extra round of lsof/ps subprocesses on top of the
background poll. The popover's data is already at most 3s stale
without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MenuContent's.task { await model.refresh() }fired an extraPortScanner.scan()(spawninglsof/pssubprocesses) every time the popover's content view appeared — i.e. every click on the menu-bar icon — on top ofAppModel's already-running 3-second poll loop, which starts immediately ininit()before any menu has ever been opened. The popover's data is already at most 3s stale without the extra call.Test plan