Skip to content

Upstream the fixes and improvements made by @mcharo - #4

Open
AZMCode wants to merge 5 commits into
AZMCode:masterfrom
mcharo:master
Open

Upstream the fixes and improvements made by @mcharo#4
AZMCode wants to merge 5 commits into
AZMCode:masterfrom
mcharo:master

Conversation

@AZMCode

@AZMCode AZMCode commented Mar 4, 2022

Copy link
Copy Markdown
Owner

A list of improvements so far include:

  • A fix for patches in macOS
  • Added support for arm64
  • Initializes submodules in the download phase instead of the installation phase

If I'm missing anything, please do comment.
Also, please do comment on your success of fixing the macOS issues, I don't have the machines to test it.

I'll merge once I get approval from the author.

@AZMCode

AZMCode commented Mar 4, 2022

Copy link
Copy Markdown
Owner Author

There seems to be an error regarding the patching procedure on Ubuntu.
Should I fork to fix it myself, or should I give you some time to figure that out?

@kamontat

Copy link
Copy Markdown

I would love to see this merge.

iGEL pushed a commit to pitch-io/asdf-jq that referenced this pull request Feb 1, 2024
Migrated code from AZMCode#7

Thanks @timdp!

Test Plan:
- [x] Uninstall jq, and then ran `asdf install jq 1.6`, validated that I saw a correct guess and download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants