Fixed minimizer input (lbfgsb method) and added dEdx to the interpolation parquet. #275
Open
danielaramirez415 wants to merge 4 commits intoATTPC:mainfrom
Open
Fixed minimizer input (lbfgsb method) and added dEdx to the interpolation parquet. #275danielaramirez415 wants to merge 4 commits intoATTPC:mainfrom
danielaramirez415 wants to merge 4 commits intoATTPC:mainfrom
Conversation
added 4 commits
April 10, 2026 16:23
… dedx to the interpolation parquet file
… dedx to the interpolation parquet file
… dedx to the interpolation parquet file
… dedx to the interpolation parquet file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent:
Add residual array to minimizer in lbfgsb solver and extra corrections to the distance square errors. Furthermore, the trajectory from the mesh is now trimmed by data length in the TrackInterpolation function. And, the interpolation parquet file now outputs dEdx depending on the PID used.