Migrate to ATRAPS LLC: copyright, clippy fix, trusted publishing - #1
Merged
Conversation
`structures::types` matched on `align_up(...)` and returned None in the None arm, which is exactly what `?` does. Clippy did not flag this when CI last ran, but the workflow pins dtolnay/rust-toolchain@stable, so the lint now fires and fails the `-D warnings` gate on every build. No behaviour change.
Record ATRAPS LLC as copyright holder following the executed IP assignment. The Apache-2.0 appendix named Johann Kempter personally and carried the wrong year: every commit in this repo dates to 2026, not 2025. - LICENSE: appendix now reads "Copyright 2026 ATRAPS LLC" - NOTICE: added, per Apache-2.0 section 4(d) attribution channel - Cargo.toml: drop deprecated `authors`; point `repository` at the org - README: name the holder in the license section
Replace the long-lived CARGO_REGISTRY_TOKEN repo secret with a short-lived OIDC token minted per run by crates-io-auth-action and revoked when the job ends. Also gate the job on the release commit being contained in main: a release can be cut from any commit, including one that never landed on main, so the `release: published` trigger alone does not imply it.
`cargo update` within existing constraints. The only direct dependency, goblin, was already at its latest release.
0.4.0 is already published and its metadata is immutable, so the corrected copyright holder, dropped `authors` field, and organisation repository URL only reach crates.io in a new version. The CHANGELOG compare links are repointed at the org in the same commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of this crate to ATRAPS LLC ownership, per TRANSFER.md.
fix: use?instead of a match—structures::typesmatched onalign_up(...)and returnedNonein theNonearm, which is exactly what?does. Clippy did not flag this when CI last ran, but the workflow pinsdtolnay/rust-toolchain@stable, so the lint now fires and would fail this PR regardless of the migration. No behaviour change.chore: assign copyrightLICENSEappendix now readsCopyright 2026 ATRAPS LLC. It named Johann Kempter personally and said 2025, which no commit supports — this history is entirely 2026.NOTICEadded;authorsdropped;repositoryrepointed at the org; README names the holder.ci:— trusted publishing replaces the storedCARGO_REGISTRY_TOKEN, and the job refuses to publish a release whose commit is not contained inmain.build:—cargo update; goblin, the only direct dependency, was already latest.chore: release 0.4.1— 0.4.0 is published and immutable, so the corrected metadata only reaches crates.io in a new version. CHANGELOG compare links repointed at the org.Verified locally: 254 tests pass, clippy clean, fmt clean,
cargo packageshipsLICENSEandNOTICE.