Reverse bucket-prefix expansion for re-submission#414
Merged
Conversation
AndrewPlayer3
approved these changes
Jun 29, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in SciDev Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized we can just reverse the bucket-prefix expansion done by the HyP3 API directly since it's a straight-forward replacement with the replacement's values preserved in the job dict.
I also cleaned up the mock job helper in
conftest.pyand forced all arguments to be passed via kwargs for clarity.fixes #412