Skip to content

Fix VerificationReport to preserve original input_dump path#88

Open
ChandruRavi3708 wants to merge 1 commit into
AOSSIE-Org:mainfrom
ChandruRavi3708:bug_resolve
Open

Fix VerificationReport to preserve original input_dump path#88
ChandruRavi3708 wants to merge 1 commit into
AOSSIE-Org:mainfrom
ChandruRavi3708:bug_resolve

Conversation

@ChandruRavi3708
Copy link
Copy Markdown

@ChandruRavi3708 ChandruRavi3708 commented May 30, 2026

Addressed Issues:

Fixes #74

Screenshots/Recordings:

N/A

Additional Notes:

This PR fixes an issue in verify_preprocessing() where Path.resolve() modified the user-provided input_dump path before storing it in VerificationReport.input_dump.

Changes made:

  • Preserved the original input_dump path string before calling Path.resolve()
  • Continued using the resolved path internally for processing and validation
  • Updated VerificationReport.input_dump to store the original user-supplied path

Validation performed:

  • tests/test_verify.py::TestHappyPath::test_report_stores_input_dump_path → Passed
  • Full tests/test_verify.py suite → 37/37 tests passed
  • Full project test suite executed; unrelated failures in experiments/checkpoint_reproducibility were observed due to platform-specific /tmp path handling on Windows and are not introduced by this change

Checklist

  • My code follows the project's code style and conventions
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contributing Guidelines

Summary by CodeRabbit

  • Bug Fixes
    • Fixed verification reports to preserve the original input_dump value instead of the converted path.

Review Change Stack

@github-actions github-actions Bot added bug Something isn't working backend python labels May 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Walkthrough

verify_preprocessing now captures the original input_dump string argument before converting it to a Path object and storing it in a local variable. This preserved original value is then used when constructing the VerificationReport, ensuring the report's input_dump field matches the caller-supplied input string rather than the resolved path.

Changes

Preserve original input dump path

Layer / File(s) Summary
Original input path preservation
openverifiablellm/verify.py
verify_preprocessing stores the original input_dump string before Path conversion, then uses that preserved value when constructing VerificationReport.input_dump to maintain the caller-provided path string without resolution-induced changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Python Lang

🐰 A path now stays true,
No Windows casing tricks in view,
Original preserved bright,
VerificationReport gets it right! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: preserving the original input_dump path in VerificationReport instead of using the resolved path.
Linked Issues check ✅ Passed The code changes directly address the requirement in issue #74 by capturing the original input_dump string before Path.resolve() and using it in VerificationReport.input_dump.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of preserving the original input_dump path; no out-of-scope modifications are present.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/XS and removed size/XS labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: verify_preprocessing() stores resolved path instead of original in VerificationReport

1 participant