Fix VerificationReport to preserve original input_dump path#88
Fix VerificationReport to preserve original input_dump path#88ChandruRavi3708 wants to merge 1 commit into
Conversation
Walkthrough
ChangesPreserve original input dump path
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Addressed Issues:
Fixes #74
Screenshots/Recordings:
N/A
Additional Notes:
This PR fixes an issue in
verify_preprocessing()wherePath.resolve()modified the user-providedinput_dumppath before storing it inVerificationReport.input_dump.Changes made:
input_dumppath string before callingPath.resolve()VerificationReport.input_dumpto store the original user-supplied pathValidation performed:
tests/test_verify.py::TestHappyPath::test_report_stores_input_dump_path→ Passedtests/test_verify.pysuite → 37/37 tests passedexperiments/checkpoint_reproducibilitywere observed due to platform-specific/tmppath handling on Windows and are not introduced by this changeChecklist
Summary by CodeRabbit