Add encoder side validation of the cropping window setting - #5346
Open
xinzhao-apple wants to merge 1 commit into
Open
Add encoder side validation of the cropping window setting#5346xinzhao-apple wants to merge 1 commit into
xinzhao-apple wants to merge 1 commit into
Conversation
With --enable-cropping-window=1, avmenc accepted conformance window offsets that its own decoder rejects with AVM_CODEC_UNSUP_BITSTREAM, producing undecodable streams: offsets off the chroma grid, offsets leaving the window empty, and non-zero offsets combined with --resize-mode (the decoder rescales the offsets by frame_size/max_frame_size, so an even offset can scale to an odd position). Apply the decoder's constraints in the encoder, so encoder will avoid generating illegal bitstreams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --enable-cropping-window=1, avmenc accepted conformance window offsets that its own decoder rejects with AVM_CODEC_UNSUP_BITSTREAM, producing undecodable streams: offsets off the chroma grid, offsets leaving the window empty, and non-zero offsets combined with --resize-mode (the decoder rescales the offsets by frame_size/max_frame_size, so an even offset can scale to an odd position).
This PR applies the decoder's constraints in the encoder, so encoder will avoid generating illegal bitstreams.