Skip to content

Add 1-pass real-time CBR rate control support - #5328

Merged
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
jianj-g:rtc-cbr-rate-control
Aug 28, 2026
Merged

Add 1-pass real-time CBR rate control support#5328
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
jianj-g:rtc-cbr-rate-control

Conversation

@jianj-g

@jianj-g jianj-g commented Aug 26, 2026

Copy link
Copy Markdown

No description provided.

@leolzhao

Copy link
Copy Markdown
Contributor

Could you please share some results for the added real-time CBR rate control support? @jianj-g

@jianj-g

jianj-g commented Aug 27, 2026

Copy link
Copy Markdown
Author

Could you please share some results for the added real-time CBR rate control support? @jianj-g

Here's the rate control (frame size) for a vga clip. You can see that only key frame is huge and the size of all inter frames are relatively stable to achieve CBR.

Around frame 100 there're a lot of motion in the clip, so the frame sizes fluctuate, which also makes sense.

cbr_frame_size_chart

@jianj-g
jianj-g requested a review from leolzhao August 27, 2026 15:04
@jianj-g
jianj-g force-pushed the rtc-cbr-rate-control branch from 4404286 to 3bc518f Compare August 27, 2026 15:31
@leolzhao
leolzhao force-pushed the rtc-cbr-rate-control branch from 3bc518f to 0a6c16e Compare August 27, 2026 18:15
@leolzhao
leolzhao enabled auto-merge (squash) August 27, 2026 18:15
@jianj-g
jianj-g force-pushed the rtc-cbr-rate-control branch from bff642b to 54dcf84 Compare August 27, 2026 21:28
@jianj-g
jianj-g force-pushed the rtc-cbr-rate-control branch from 54dcf84 to a8daa8d Compare August 28, 2026 13:57
@urvangjoshi

Copy link
Copy Markdown
Contributor

@jianj-g : pls don't rebase further. I'll rebase and merge after CI finishes.

@urvangjoshi
urvangjoshi disabled auto-merge August 28, 2026 15:33
@leolzhao
leolzhao force-pushed the rtc-cbr-rate-control branch from a8daa8d to eca68b1 Compare August 28, 2026 16:19
@jianj-g

jianj-g commented Aug 28, 2026

Copy link
Copy Markdown
Author

@jianj-g : pls don't rebase further. I'll rebase and merge after CI finishes.

Does it block auto-merge being not up to date with the base branch?

@urvangjoshi

Copy link
Copy Markdown
Contributor

@jianj-g : pls don't rebase further. I'll rebase and merge after CI finishes.

Does it block auto-merge being not up to date with the base branch?

What we have been doing is wait for CI to finish, then rebase and force-merge without waiting for CI to finish.
But if you rebase on your own, we don't know if CI had finished and succeeded on previous rebase or not. (I couldn't see previous CI pipeline runs for the PR on Github).

@urvangjoshi
urvangjoshi force-pushed the rtc-cbr-rate-control branch from eca68b1 to e55edf4 Compare August 28, 2026 22:43
@urvangjoshi
urvangjoshi merged commit 6a36d4e into AOMediaCodec:av2-enc Aug 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants