Updated Dockerfile and ANNIEDirt for ANNIE+Ar Simulations - #3
Open
Noah-Everett wants to merge 23 commits into
Open
Updated Dockerfile and ANNIEDirt for ANNIE+Ar Simulations#3Noah-Everett wants to merge 23 commits into
Noah-Everett wants to merge 23 commits into
Conversation
… different account
marc1uk
reviewed
Dec 20, 2024
| ########################### | ||
| RUN source /setup_Dockerfile.sh \ | ||
| && git clone --depth 1 https://github.com/ANNIEsoft/GENIE-v3 /GENIE \ | ||
| && git clone --depth 1 https://github.com/Noah-Everett/GENIE_ANNIESoft /GENIE \ |
Collaborator
There was a problem hiding this comment.
Hi Noah, can we set this back to the ANNIESoft fork?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the Dockerfile to work as of Sep 1, 2024. I have also included additional code to allow ANNIEDirt to work for ANNIE with argon simulations (what Jingbo is proposing). I understand if these changes should not be pushed to the main ANNIE repo. I believe these changes are only in
src/PrimaryGeneratorAction.ccfrom lines 183-188 andsrc/SteppingAction.ccfrom lines 106-111. If these changes are included in the PR they should not change the function of ANNIEDirt without included argon in the FV.