fix: skill reload poll loop delays first pull by full interval#46
Merged
Conversation
The skill reload poll loop waited for the full interval (30s default) before making its first pull. A second user starting their proxy with skill_reload_mode=poll would wait 30s before getting any shared skills. Now the first iteration pulls immediately, then follows the normal interval schedule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_skill_reload_poll_loopto pull immediately on first iteration instead of waiting 30sskill_reload_mode=poll, a second team member's proxy would wait a full interval before pulling any shared skills from Nacos, causing the first request to run without skill injectionTest plan
pytest tests/test_multiuser_nacos_pull.py— 6 tests passpytest tests/test_session_upload_trigger.py— existing poll mode tests unchangedpytest tests/test_nacos_skill_hub.py— existing Nacos tests unchanged