Fix Nacos skill backend draft and version handling#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Fix Nacos-backed skill sharing so skill registry storage can be configured independently from session/object storage, Nacos draft and review states are handled without duplicate version creation, and evolve can read the right remote skill content across draft, reviewed, and published-version cases.
Brief changelog
sharing.skill_backendso skill assets can use Nacos while sessions and validation data continue using local/OSS/S3 storage.sharing.backend=nacoscompatibility while avoiding accidental object-store inference for Nacos-only configs.vNandx.x.xNacos version formats, defaulting new Nacos skills to0.0.1.editingVersion,reviewingVersion, andreviewedversions before upload so existing working versions are not bypassed by creating the next version.Verifying this change
git diff --check.Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.