Add suggested citations to DMRG banner - #129
Conversation
| << "* Recommended citation in scientific publications: *\n" | ||
| << "* This code used the ALPS [1] implementation [2] of DMRG [3-6]. *\n" | ||
| << "* [1] JSTAT (2011) P05001; *\n" | ||
| << "* [2] A.E. Feiguin, The Density Matrix Renormalization Group. In: *\n" |
There was a problem hiding this comment.
Hi, I checked out the list of citations, and just wanted to ask for two minor clarifications:
Could it be that Ref [2] is not currently listed on the website https://alps.comp-phys.org/documentation/pubs/refs/ ? The DOI of [2] appears to be 10.1007/978-3-642-35106-8_2. Should it be added to the website?
Also, the website lists "M. Dolfi, B. Bauer, S. Keller, A. Kosenkov, T. Ewart, A. Kantian, T. Giamarchi, and M. Troyer, Matrix product state applications for the ALPS project, Comput. Phys. Commun. 185, 3430 (2014).", which doesn't seem to be in this list? Should it be added here?
skilledwolf
left a comment
There was a problem hiding this comment.
I noticed a minor discrepancy in comparison to the website's citation list (see comment), but I don't think it's blocking for this PR.
It might be worth follow-up PR for the banner and the website at some point, to make sure we are consistent.
|
Hi,
Could it be that Ref [2] is not currently listed on the website https://alps.comp-phys.org/documentation/pubs/refs/ ? The DOI of [2] appears to be 10.1007/978-3-642-35106-8_2. Should it be added to the website?
Correct. That is not properly acknowledged at this time.
Also, the website lists "M. Dolfi, B. Bauer, S. Keller, A. Kosenkov, T. Ewart, A. Kantian, T. Giamarchi, and M. Troyer, Matrix product state applications for the ALPS project, Comput. Phys. Commun. 185, 3430 (2014).", which doesn't seem to be in this list? Should it be added here?
No it should not. This is the MPS code that had no maintainer, so it got removed. It was within the dmrg directory.
Have a look at the PR on the website that does this same update to the website.
Emanuel
|
|
...adding Adrian (since he's the final authority on the dmrg code and cross-checked the citation statement) and Vito (since he wants consistent citation blocks). |
vws100
left a comment
There was a problem hiding this comment.
The format for citations that we agreed on should have 3 tiers. @afeiguin is this correct ? If so we can limit the citations to this. ALPS release will have to be updated to 3.0 since you've update
- Original Code:
S. White: Phys. Rev. Lett. 69, 2863 (1992);Phys. Rev. B 48, 10345 (1993)
2 . Implementation
A.E. Feiguin, The Density Matrix Renormalization Group. In:
Strongly Correlated Systems. Springer Series in Solid-State Sciences, vol 176 (2013)
- ALPS Release
|
I think the thought here is that it has three tiers. ALPS tier is our ALPS paper (Bauer 2011 for now). Implementation is Adrian's proceedings paper. Algorithm is not a single paper but a set of four references: 2 White papers (for 'original literature') and two reviews (Schollwöck, Hallberg). |
Ooolab
left a comment
There was a problem hiding this comment.
I didn't know as much history as you. But I will approve this and let you guys decide.
Summary
Testing
cmake --build build --target dmrg -j4build/applications/dmrg/dmrg/dmrg --helpgit diff --check