Skip to content

Remove obsolete lattice-preview GUI - #111

Merged
skilledwolf merged 2 commits into
masterfrom
WIP/remove-lattice-preview
Aug 18, 2026
Merged

Remove obsolete lattice-preview GUI#111
skilledwolf merged 2 commits into
masterfrom
WIP/remove-lattice-preview

Conversation

@skilledwolf

@skilledwolf skilledwolf commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the unmaintained wxPython/VTK lattice-preview GUI
  • remove its launcher and private Python helper modules
  • remove its CMake installation block and Debian install-manifest entry

Why

The feature was introduced in 2009 and last updated in 2016. Its launcher still relies on Python 2 syntax and contains broken environment-variable names (BUILDIDR and PHTHONPATH), while the GUI uses legacy wxPython APIs and has no dependency detection for wxPython or VTK. Ordinary non-wheel builds install it even when those runtime dependencies are unavailable.

Removing the feature as a unit is safer than retaining or modernizing its otherwise-unused tool/license.py helper.

Scope

The removal is self-contained: it deletes only the obsolete GUI, its private helpers, its build and installation rules, and its packaging-manifest entry.

Validation

  • fresh minimal CMake configuration with Python, applications, examples, and tests disabled
  • no remaining lattice-preview or helper-module references
  • git diff --check

The commit includes [skip ci]; these removal-only changes were validated locally without starting CI.

@skilledwolf
skilledwolf force-pushed the WIP/remove-lattice-preview branch from ea69cc0 to 1f3922b Compare July 24, 2026 16:36
@skilledwolf
skilledwolf changed the base branch from master to modernization/pyalps-nanobind-wheel July 24, 2026 16:36
@egull

egull commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

I'm ok with removing it but @wistaria is the author. Synge, should we fix it, rather than remove it?

@egull
egull requested review from Ooolab and wistaria August 16, 2026 22:04

@Ooolab Ooolab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with either keeping or removing the lattice-preview GUI. @vws100 pointed out another lattice drawing repo: https://github.com/ALPSim/latticegraph_designer , which I forked to our repo a while ago. It is working now, but we would need to do some work to include it in ALPS. @vws100 , could you weigh in on whether to keep/remove or include the other repo you found.

@skilledwolf

Copy link
Copy Markdown
Collaborator Author

Please note: PRs #107 and #111, #112 and #114 were stacked (only #107 was targeted into master). That was my bad, I'm rebasing them now, so we can land them independently for the release.

@skilledwolf
skilledwolf changed the base branch from modernization/pyalps-nanobind-wheel to master August 17, 2026 19:33
@skilledwolf
skilledwolf force-pushed the WIP/remove-lattice-preview branch from 1f3922b to 1501d7d Compare August 17, 2026 19:33
@skilledwolf
skilledwolf force-pushed the WIP/remove-lattice-preview branch from 1501d7d to b81da6b Compare August 17, 2026 19:52
@skilledwolf skilledwolf self-assigned this Aug 17, 2026
Conflicts: tool/config.py.in, tool/license.py, and tool/preview.py were
touched on master by the licensing sweep but are deleted by this branch;
all three deletions are kept, as this branch removes the lattice-preview
GUI as a unit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@skilledwolf
skilledwolf marked this pull request as ready for review August 18, 2026 08:06
@egull

egull commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Not getting anything from @wistaria . I propose we remove and reintroduce if Synge would like to have it updated. Happy to approve the PR.

@egull
egull self-requested a review August 18, 2026 15:40

@egull egull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving removal. We can cycle back to this later to either modernize the code or integrate the other outside repo, but that's a decision for later.

@skilledwolf
skilledwolf merged commit 9b4b376 into master Aug 18, 2026
83 checks passed
@skilledwolf
skilledwolf deleted the WIP/remove-lattice-preview branch August 18, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants