Remove obsolete lattice-preview GUI - #111
Conversation
ea69cc0 to
1f3922b
Compare
|
I'm ok with removing it but @wistaria is the author. Synge, should we fix it, rather than remove it? |
Ooolab
left a comment
There was a problem hiding this comment.
I am ok with either keeping or removing the lattice-preview GUI. @vws100 pointed out another lattice drawing repo: https://github.com/ALPSim/latticegraph_designer , which I forked to our repo a while ago. It is working now, but we would need to do some work to include it in ALPS. @vws100 , could you weigh in on whether to keep/remove or include the other repo you found.
1f3922b to
1501d7d
Compare
1501d7d to
b81da6b
Compare
Conflicts: tool/config.py.in, tool/license.py, and tool/preview.py were touched on master by the licensing sweep but are deleted by this branch; all three deletions are kept, as this branch removes the lattice-preview GUI as a unit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Not getting anything from @wistaria . I propose we remove and reintroduce if Synge would like to have it updated. Happy to approve the PR. |
egull
left a comment
There was a problem hiding this comment.
Approving removal. We can cycle back to this later to either modernize the code or integrate the other outside repo, but that's a decision for later.
Summary
lattice-previewGUIWhy
The feature was introduced in 2009 and last updated in 2016. Its launcher still relies on Python 2 syntax and contains broken environment-variable names (
BUILDIDRandPHTHONPATH), while the GUI uses legacy wxPython APIs and has no dependency detection for wxPython or VTK. Ordinary non-wheel builds install it even when those runtime dependencies are unavailable.Removing the feature as a unit is safer than retaining or modernizing its otherwise-unused
tool/license.pyhelper.Scope
The removal is self-contained: it deletes only the obsolete GUI, its private helpers, its build and installation rules, and its packaging-manifest entry.
Validation
lattice-previewor helper-module referencesgit diff --checkThe commit includes
[skip ci]; these removal-only changes were validated locally without starting CI.