feat(navigation): implement correct page transition lifecycle and progressive settings loading (#199)#200
Merged
Merged
Conversation
…gressive settings loading (#199) - NavigationManager: add Task.Delay(TransitionDuration + 100ms) before OnNavigatedTo so CrossFade completes first - NavigationManager: add OnNavigatingTo lifecycle hook for pre-transition lightweight init - NavigationManager: remove OnNavigatingFrom, unify NavigateTo/NavigateToRoot overloads - NavigationConstants: new class with TransitionDuration as single source of truth - MainWindow.axaml: remove IsEnabled/IsBusy binding that cancelled in-progress transitions; bind CrossFade Duration to NavigationConstants - SettingsPageViewModel: extract InitXxxSettings() methods, progressive loading with InvokeAsync(Background) - SettingsPageView.axaml: fix DataTemplate DataContext binding causing InvalidCastException - GameDetailsViewModel: implement OnNavigatingTo to set Game before transition - GameListViewModel: Games nullable to prevent empty state flash during loading - GameListView.axaml: replace inline empty state with EmptyStateView control - Remove unused asset Lara_Croft_Flashlight.png - LocalizationManager.GetSupportedLanguages: made async Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199