Skip to content

Add time taken to the completion message#1374

Merged
ubdbra001 merged 3 commits into
AFM-SPM:mainfrom
ubdbra001:i1294-add-elapsed-to-output
Jul 23, 2026
Merged

Add time taken to the completion message#1374
ubdbra001 merged 3 commits into
AFM-SPM:mainfrom
ubdbra001:i1294-add-elapsed-to-output

Conversation

@ubdbra001

@ubdbra001 ubdbra001 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

An attempt to resolve #1294

This records the datetime for each function in run_modules that later calls completion_message, and then passes it when completion_message is called to calculate the duration elapsed.

It doesn't break any tests but it would be good if someone else could test it on a real run.

@ubdbra001
ubdbra001 force-pushed the i1294-add-elapsed-to-output branch from f171c66 to 10f3261 Compare June 24, 2026 15:06
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.18%. Comparing base (98bc988) to head (812b0a6).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   84.11%   84.18%   +0.06%     
==========================================
  Files          31       31              
  Lines        6448     6474      +26     
==========================================
+ Hits         5424     5450      +26     
  Misses       1024     1024              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SylviaWhittle

Copy link
Copy Markdown
Collaborator

@SylviaWhittle to check if this works in actual usage.

@ubdbra001
ubdbra001 force-pushed the i1294-add-elapsed-to-output branch from 630475a to 812b0a6 Compare July 16, 2026 14:14
@SylviaWhittle
SylviaWhittle marked this pull request as ready for review July 23, 2026 13:13

@SylviaWhittle SylviaWhittle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Works. :)

Thank you.

@ubdbra001
ubdbra001 added this pull request to the merge queue Jul 23, 2026
Merged via the queue into AFM-SPM:main with commit 726b3ef Jul 23, 2026
15 checks passed
@ubdbra001
ubdbra001 deleted the i1294-add-elapsed-to-output branch July 23, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] : Add time taken to process to output.

2 participants