Updated notebooks#1361
Conversation
ubdbra001
left a comment
There was a problem hiding this comment.
Had a look through this and I have a couple of comments:
- The formatting of the text in the notebooks needs to be reviewed. Specifically, the lines are broken at seemingly random places which makes following the prose a bit harder than it needs to be.
- Plotting in Notebook 1 is not working/not showing. May be related to some of the other issues discussed around plotting.
- The Load section in Notebook 3 is not working for me. The file it's trying to load
minicircle.topostatsdoesn't exist.minicircle_small.topostatsdoes but it is seeing it as a directory and skipping over it.
|
Thanks @ubdbra001
|
I'll note any other things I find in subsequent comments. |
|
Occurs anywhere the |
|
Occurs in the first cell in the |
Possibly not related to this PR directly, but I get this error when running |
Notebooks have been updated to run with the current version of Topostats (v2.4.x)
The overall objective of each notebook (introduce TopoStats's processing steps, statistics and plots) have not changed but the actual code has a large amount of changes due to how much TopoStats has changed.
Note: The issue with notebook 01 not displaying plots inline has not been fixed, but the cause of it is
topolyand an issue has been created in the repo to address this.