Optimize blocking hot path and storage inefficiencies#87
Draft
ACK-J wants to merge 1 commit into
Draft
Conversation
Compile allowlists into Sets/CIDRs, return sync webRequest decisions when DNS is unnecessary, skip clean activity flushes, store native values, and cut redundant popup/hostname work on the blocking path. Co-authored-by: Hacks and Hops <ACK-J@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the efficiency review items #2, #3, #5–#7 and mediums #8–#12 (DNS / Selective Allow double-work left alone).
Changes
evaluateRequestSyncreturns a plain{ cancel }when DNS is not needed; background peeks the warm compiled allowlist and avoids Promise scheduling on first-party / allowlisted / literal-local / known-TMX hits.compileAllowlist()preclassifies exact hosts, portless IPs, and CIDRs (with masks) so matching is Set/integer checks instead of per-requestURL+ CIDR reparsing.getTabActivityround-trip populates both blocked ports and hosts.structuredClonewith targeted Set→array snapshots.JSON.stringify; legacy string cells still decode on read.originHostinto notifications.Tests
npm test— 679 passed.Out of scope
DNS-on-every-third-party-host (#1) and Selective Allow double-parse / uncached cross-origin list (#4).