Skip to content

Competing risk - #78

Merged
csmith701 merged 12 commits into
mainfrom
prob-to-rate
Sep 4, 2026
Merged

Competing risk#78
csmith701 merged 12 commits into
mainfrom
prob-to-rate

Conversation

@csmith701

@csmith701 csmith701 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Includes a series of methodologic updates including:

@csmith701
csmith701 requested a review from pearsonca August 27, 2026 12:48
@csmith701
csmith701 marked this pull request as ready for review August 27, 2026 12:48

@pearsonca pearsonca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assorted questions below!

Comment thread inst/auxillary/simulation.R Outdated
Comment thread inst/auxillary/simulation.R Outdated
Comment thread inst/auxillary/simulation.R
Comment thread inst/stan/hmm.stan

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's a bit unclear to me here: will this handle the multistrain case, if those strains both have multiple infectious states in their chain? as in, if i have strain A and B, and both have pre-symptomatic infectious states (or maybe just one does), does this indexing machinery work correctly?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it should be able to handle that scenario just fine.

Comment thread inst/stan/hmm_cov.stan

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a ton of code duplication between this an not-cov - is there someway to have the deduplicated code, and then an import of non-cov vs cov calculations?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's something I have been thinking about. The issue is that in the covariate version the infection probabilities become matrices. Still I think some opportunity to deduplicate.

Comment thread R/hestia_functions.R
Comment thread R/hestia_functions.R
Comment thread R/hestia_functions.R
Comment thread tests/testthat/test-run_model.R Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to be a fairly complicated "toy" example - possibly to more narrowly / simply test?

csmith701 and others added 3 commits September 3, 2026 09:51
Co-authored-by: Carl A. B. Pearson <pearsonca@users.noreply.github.com>
Co-authored-by: Carl A. B. Pearson <pearsonca@users.noreply.github.com>
@csmith701
csmith701 merged commit c6626a8 into main Sep 4, 2026
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants