Internal configuration implementation, with overrides and env interpolation#17
Open
bschroeter wants to merge 2 commits into
Open
Internal configuration implementation, with overrides and env interpolation#17bschroeter wants to merge 2 commits into
bschroeter wants to merge 2 commits into
Conversation
Collaborator
Author
|
@abhaasgoyal, the tests are currently set up to really only work on NCI with access to specific data paths. We should update these tests to be in-memory (temp directory) or skippable on GH actions. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Collaborator
Author
|
Switched to in-memory paths for testing. @abhaasgoyal, why would the test be failing under different circumstances? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
Internal configuration implementation with default configuration as part of the installation.
Environment variables are passed in via Jinja templating through hpcpy's interpolation functionality.
This will allow us to modify cluster configuration via a YAML file, as opposed to editing source code directly.
I haven't touched the original config file in the root of the project, but we should move this out into a more appropriate place.
Tests pass, happy to walk you through the changes.