Skip to content

Internal configuration implementation, with overrides and env interpolation#17

Open
bschroeter wants to merge 2 commits into
mainfrom
9-move-constants-to-internal-default-config-file
Open

Internal configuration implementation, with overrides and env interpolation#17
bschroeter wants to merge 2 commits into
mainfrom
9-move-constants-to-internal-default-config-file

Conversation

@bschroeter

Copy link
Copy Markdown
Collaborator

Fixes #9.

Internal configuration implementation with default configuration as part of the installation.

Environment variables are passed in via Jinja templating through hpcpy's interpolation functionality.

This will allow us to modify cluster configuration via a YAML file, as opposed to editing source code directly.

I haven't touched the original config file in the root of the project, but we should move this out into a more appropriate place.

Tests pass, happy to walk you through the changes.

@bschroeter bschroeter requested a review from abhaasgoyal June 3, 2026 05:12
@bschroeter bschroeter linked an issue Jun 3, 2026 that may be closed by this pull request
@bschroeter

Copy link
Copy Markdown
Collaborator Author

@abhaasgoyal, the tests are currently set up to really only work on NCI with access to specific data paths. We should update these tests to be in-memory (temp directory) or skippable on GH actions.

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@bschroeter

Copy link
Copy Markdown
Collaborator Author

Switched to in-memory paths for testing. @abhaasgoyal, why would the test be failing under different circumstances? push passes, but pull_request does not... In any case, we should probably not be running both if they are not producing the same results...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move constants to internal default config file.

1 participant