Skip to content

Several fixes and improvements#62

Merged
micaeljtoliveira merged 3 commits into
mainfrom
improvements
Jun 18, 2026
Merged

Several fixes and improvements#62
micaeljtoliveira merged 3 commits into
mainfrom
improvements

Conversation

@micaeljtoliveira

@micaeljtoliveira micaeljtoliveira commented Jun 2, 2026

Copy link
Copy Markdown
Member

These fix issues found when updating the ESM1.6 scaling notebook.

@codecov

codecov Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fa7faff) to head (c2724b4).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1015      1033   +18     
=========================================
+ Hits          1015      1033   +18

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micaeljtoliveira micaeljtoliveira marked this pull request as draft June 2, 2026 01:22
manodeep
manodeep reviewed Jun 2, 2026
View reviewed changes

@manodeep manodeep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I know you haven't yet asked for a review - but I did one anyway :D)

Small suggestion to make the test clearer, if you do accept it, the change will need to be applied for the other instances of expected_regions that follow

Comment thread tests/test_experiment.py Outdated
@micaeljtoliveira micaeljtoliveira force-pushed the improvements branch 2 times, most recently from 9182992 to b1021cc Compare June 9, 2026 03:49
@micaeljtoliveira micaeljtoliveira marked this pull request as ready for review June 11, 2026 01:49
@micaeljtoliveira

micaeljtoliveira commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

@manodeep I think this is ready to go, just needs one final review.

manodeep
manodeep reviewed Jun 11, 2026
View reviewed changes

@manodeep manodeep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of that one comment, everything else looks good!

For that comment, may be just explain why the double parsing is required

Comment thread tests/test_experiment.py Outdated
@micaeljtoliveira

micaeljtoliveira commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@manodeep Still needing an approval here (or further comments) ;)

@manodeep

manodeep commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

LGTM

@micaeljtoliveira

micaeljtoliveira commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Thanks!

@micaeljtoliveira micaeljtoliveira merged commit 28fd7de into main Jun 18, 2026
8 checks passed
@micaeljtoliveira micaeljtoliveira deleted the improvements branch June 18, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodeep manodeep manodeep approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@micaeljtoliveira @manodeep