Implement add_rose_experiment and delete/archive/run_experiments to CylcRoseManager#59
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 948 1015 +67
=========================================
+ Hits 948 1015 +67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
micaeljtoliveira
requested changes
May 7, 2026
Member
|
@edoyango Forgot to say in the review that you need to rebase on main to get the Conda build CI failure fixed. |
edoyango
force-pushed
the
cycl-rose-manager
branch
from
fec1a39 to
4f4890a
Compare
edoyango
force-pushed
the
cycl-rose-manager
branch
from
602a727 to
1dc48ef
Compare
micaeljtoliveira
requested changes
Jun 18, 2026
micaeljtoliveira
left a comment
micaeljtoliveira
left a comment
Member
There was a problem hiding this comment.
@edoyango Thanks for the changes! I've got another couple of comments. Almost there ;)
edoyango
force-pushed
the
cycl-rose-manager
branch
from
1dc48ef to
bb8e5b6
Compare
micaeljtoliveira
approved these changes
Jun 18, 2026
Member
|
@edoyango You need to sign your commits to unblock the merge. |
…to CylcRoseManager Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Both PayuManager and CylcRoseManager had identical logic for validating and resolving experiment name selections. Move it to a single base-class helper so each subclass only owns its deletion mechanics. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the Gadi-specific /scratch/<project>/<user>/cylc-run/<rose> run path construction (and PROJECT env lookup) with an explicit run_path argument, keeping CylcRoseManager general across sites. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Move the shared selection, validation and manager-state bookkeeping into a concrete ProfilingManager.delete_experiments, which delegates the per-experiment on-disk deletion to a deferred _delete_experiment method implemented by each concrete manager. This inverts the dependency so control flows from the abstract class to its children, replacing the _resolve_names helper. CylcRoseManager._delete_experiment removes the experiment and run directories. PayuManager keeps a thin delete_experiments override to accept remove_repo_dir and implements _delete_experiment via the experiment runner per branch; its public selection arguments are renamed branches/all_branches -> experiments/all_experiments for consistency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Micael Oliveira <micael.oliveira@anu.edu.au>
edoyango
force-pushed
the
cycl-rose-manager
branch
from
67c2cd7 to
726d47d
Compare
Collaborator
Author
done! I forgot to setup signing on my new machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements features in CylcRoseManager that are missing (compared to PayuManager).
run_experiments uses the
rose suite-runcmd as I don't think there's a good python api to use for rose.rose suite-runis executed with--no-gcontrolso the gui isn't launched. Like inPayuManager, the experiments' status is set to DONE immediately after launching the pipeline.