Extend the types of data the profiling parsers can handle#56
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 906 948 +42
=========================================
+ Hits 906 948 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
054f5df to
7bf512e
Compare
Member
Author
There was a problem hiding this comment.
Pull request overview
Extends the profiling pipeline to support additional parser output shapes (hierarchical/nested region trees and per-processing-element “pe” data) and to transform those into usable xarray.Dataset forms within ProfilingLog.parse().
Changes:
- Add
flatten_hierarchical()andaggregate_pe_data()utilities inaccess.profiling.parser. - Update
ProfilingLog.parse()to automatically flatten hierarchical parser outputs and to build 2D datasets for per-PE outputs. - Expand tests to cover hierarchical parsing, per-PE datasets, and PE aggregation statistics; clarify metric descriptions/documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_parser.py | Adds unit tests for aggregate_pe_data() output variables and error handling. |
| tests/test_experiment.py | Adds coverage for ProfilingLog.parse() with hierarchical and per-PE parser outputs. |
| src/access/profiling/parser.py | Documents supported parser output shapes; adds hierarchical flattening + PE aggregation helpers. |
| src/access/profiling/metrics.py | Clarifies metric semantics and naming conventions around aggregation dimensions. |
| src/access/profiling/experiment.py | Enhances ProfilingLog.parse() to accept hierarchical and per-PE parser outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- now hierarchical data is properly handled - data per processing element (PE) is also taken into account Several changes to make this work: - new metrics are introduced and the meaning of existing metrics is clarified - added function to aggregate data over PEs - added function to convert from hierarchical to flat
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
0f2e3c9 to
99e3eb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was prepared with the help of Claude Opus 4.6.