Skip to content

UI Tweaks and Logging Improvements - #216

Open
revett wants to merge 3 commits into
mainfrom
revett/task/ui-tweaks
Open

UI Tweaks and Logging Improvements#216
revett wants to merge 3 commits into
mainfrom
revett/task/ui-tweaks

Conversation

@revett

@revett revett commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Resolves #155

WIP

Greptile Summary

This PR streamlines MinIO setup, revises log timestamps and level labels, and updates the corresponding UI, documentation, and tests.

  • Makes MinIO the first provider option and defaults its signing region to us-east-1.
  • Removes the MinIO region input while retaining endpoint configuration.
  • Formats log rows with fixed-shape local timestamps and three-letter level labels.
  • Updates storage and sync integration fixtures for regionless MinIO settings.

Confidence Score: 4/5

The MinIO region regression needs to be fixed before merging because existing non-default-region production installations can no longer authenticate.

Real sync and connection testing now ignore a MinIO configuration's persisted region and sign for us-east-1, while the production settings UI removes both the region field and access to the documented custom-provider alternative.

Files Needing Attention: src/settings/settings.ts, src/settings/tab.ts, styles.css

Important Files Changed

Filename Overview
src/settings/settings.ts Forces all MinIO requests to sign for us-east-1, breaking production configurations whose server uses another region.
src/settings/tab.ts Removes the MinIO region field while production still hides the only proposed alternative, the custom provider.
src/storage/storage.ts Keeps validation aligned with the new derived MinIO region, but propagates that forced region into connection testing.
src/log/log.ts Adds tested local timestamp formatting and stable three-letter level labels.
src/log/view.ts Uses the new timestamp and level-label helpers when rendering persisted entries.
styles.css Tightens log-row spacing but makes message alignment depend on the configured monospace font having equal glyph advances.
docs/technical_settings.md Documents custom provider as the route for non-default MinIO regions without noting that production users cannot select it.

Reviews (1): Last reviewed commit: "Update log message" | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

Context used (4)

Comment thread src/settings/settings.ts
Comment on lines +261 to +263
if (settings.provider === "minio") {
return MINIO_REGION;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 MinIO signing region is forced

If a production MinIO server uses a non-default MINIO_REGION, regionFor now ignores the persisted region and signs both connection tests and sync requests for us-east-1, causing signature verification to fail with no production-visible configuration path to correct it.

Knowledge Base Used:

Comment thread styles.css
Comment on lines +136 to 140
/* Every level tag is three letters, so a single space column keeps messages aligned. */
.geode-log-level {
flex-shrink: 0;
width: 4em;
font-weight: 700;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Level column loses fixed width

The level span now relies on three characters occupying equal space, so a theme or user configuration that resolves --font-monospace to unequal glyph widths leaves DBG, INF, WRN, and ERR messages visibly misaligned.

Suggested change
/* Every level tag is three letters, so a single space column keeps messages aligned. */
.geode-log-level {
flex-shrink: 0;
width: 4em;
font-weight: 700;
}
/* Keep the level column fixed so messages align regardless of the configured font. */
.geode-log-level {
flex-shrink: 0;
width: 4em;
font-weight: 700;
}

Knowledge Base Used: Log module

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve logging

1 participant