UI Tweaks and Logging Improvements - #216
Conversation
| if (settings.provider === "minio") { | ||
| return MINIO_REGION; | ||
| } |
There was a problem hiding this comment.
MinIO signing region is forced
If a production MinIO server uses a non-default MINIO_REGION, regionFor now ignores the persisted region and signs both connection tests and sync requests for us-east-1, causing signature verification to fail with no production-visible configuration path to correct it.
Knowledge Base Used:
| /* Every level tag is three letters, so a single space column keeps messages aligned. */ | ||
| .geode-log-level { | ||
| flex-shrink: 0; | ||
| width: 4em; | ||
| font-weight: 700; | ||
| } |
There was a problem hiding this comment.
Level column loses fixed width
The level span now relies on three characters occupying equal space, so a theme or user configuration that resolves --font-monospace to unequal glyph widths leaves DBG, INF, WRN, and ERR messages visibly misaligned.
| /* Every level tag is three letters, so a single space column keeps messages aligned. */ | |
| .geode-log-level { | |
| flex-shrink: 0; | |
| width: 4em; | |
| font-weight: 700; | |
| } | |
| /* Keep the level column fixed so messages align regardless of the configured font. */ | |
| .geode-log-level { | |
| flex-shrink: 0; | |
| width: 4em; | |
| font-weight: 700; | |
| } |
Knowledge Base Used: Log module
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Resolves #155
WIP
Greptile Summary
This PR streamlines MinIO setup, revises log timestamps and level labels, and updates the corresponding UI, documentation, and tests.
Confidence Score: 4/5
The MinIO region regression needs to be fixed before merging because existing non-default-region production installations can no longer authenticate.
Real sync and connection testing now ignore a MinIO configuration's persisted region and sign for us-east-1, while the production settings UI removes both the region field and access to the documented custom-provider alternative.
Files Needing Attention: src/settings/settings.ts, src/settings/tab.ts, styles.css
Important Files Changed
Reviews (1): Last reviewed commit: "Update log message" | Re-trigger Greptile
Context used (4)