Agents → Add ponytail skill

[revett]

Problem

• Nothing in the project pushes back on bloat; typescript-as-go governs how TypeScript is written, but not whether the code needs to exist at all
• Style drift had accumulated across src/: helpers sitting above the exports they serve, ternaries where the skill asks for an if, missing blank lines before trailing returns, and comments running past the 100 character limit
• Test names still carried issue numbers, which stop meaning anything the moment the issue closes

Changes

• Vendor the ponytail skill into .agents/skills, pin it in skills-lock.json, and point AGENTS.md at it as a secondary rule to typescript-as-go
• Reorder declarations alphabetically within their export tier, so helpers now sit below the code that calls them
• Swap ternaries for if blocks, add the blank line before trailing returns, and rewrap over-long comments
• Strip issue numbers from test names, and give main.ts and settings/tab.ts the explicit .ts import extensions the rest of src/ already uses
• Fix a roadmap typo, a stale make create-dev-vault reference in .gitignore, and make contentOf in the sync integration test throw on a null body rather than quietly reading it as empty bytes

Why

• The vision asks for a codebase without bloat, and a skill that questions whether work needs to happen at all is the cheapest way to hold that line, for agents and humans alike
• No production behaviour changes here, the sweep is presentation only, so review can stay on the skill itself

Greptile Summary

This PR vendors the Ponytail agent skill and makes it secondary project guidance, while applying a behavior-preserving TypeScript style sweep.

• Adds and pins the Ponytail skill, then references it from AGENTS.md.
• Reorders declarations, expands selected ternaries into if blocks, adds spacing, wraps comments, and standardizes explicit .ts imports.
• Cleans test names and improves the sync integration test’s null-body diagnostic.
• Corrects small roadmap and development-command documentation issues.

Confidence Score: 5/5

The PR appears safe to merge because the executable changes preserve existing behavior and the remaining changes affect guidance, formatting, documentation, and tests.

The explicit TypeScript imports are supported by the configured toolchain, moved declarations retain valid initialization semantics, and the rewritten branches preserve their previous results.

Important Files Changed

Filename	Overview
.agents/skills/ponytail/SKILL.md	Adds the vendored Ponytail guidance defining minimal, YAGNI-oriented implementation practices.
AGENTS.md	Makes Ponytail secondary to the existing TypeScript and repository-specific rules.
skills-lock.json	Adds a structurally consistent pinned source and hash entry for the Ponytail skill.
src/main.ts	Standardizes local import extensions and formatting without changing plugin lifecycle behavior.
src/settings/settings.ts	Reorders declarations and replaces string truthiness with an equivalent explicit empty-string check.
src/settings/tab.ts	Standardizes import extensions and return spacing without changing settings UI behavior.
src/storage/storage.ts	Applies return-spacing style changes to storage operation branches without altering result semantics.
src/sync/execute.ts	Rewraps comments and applies formatting-only changes to sync execution logic.
src/sync/sync.ts	Reorders the SyncFault type and rewraps comments without changing sync orchestration.
src/sync/sync.itest.ts	Makes the test helper distinguish a missing response body from a malformed object body.
src/vault/fs.ts	Expands ternaries in the filesystem test harness into behaviorally equivalent conditional assignments.
src/vault/obsidian.ts	Applies equivalent branch-based path construction and declaration-order cleanup to the vault adapter.
src/vault/vault.ts	Applies equivalent explicit conditionals and declaration reordering to snapshot and path helpers.

_{Reviews (1): Last reviewed commit: "Add new skill" | Re-trigger Greptile}