Skip to content

[#212] Settings → Add MinIO as provider in settings - #213

Merged
revett merged 1 commit into
8thpark:mainfrom
kwame-Owusu:feat/add-MinIO-as-provider
Aug 11, 2026
Merged

[#212] Settings → Add MinIO as provider in settings#213
revett merged 1 commit into
8thpark:mainfrom
kwame-Owusu:feat/add-MinIO-as-provider

Conversation

@kwame-Owusu

@kwame-Owusu kwame-Owusu commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

resolves #212

Description

MinIO is currently supported, just not obvious in settings.

Changes

Add new option in the settings drop down and add MinIO options in code for the settings and the UI as well

UI

image

Tests

Verified: 494 unit tests, 30 integration tests against real MinIO.
npm run build, npm run lint, and check-comments all clean.

Greptile Summary

This PR makes MinIO a named production storage provider while retaining the existing S3-compatible client behavior.

  • Adds MinIO to persisted provider normalization, connection validation, and the production provider dropdown.
  • Adds MinIO-specific endpoint and region fields to the settings UI.
  • Updates unit, storage integration, and end-to-end sync fixtures to exercise the named MinIO provider.
  • Updates technical settings documentation for the four-provider model.

Confidence Score: 5/5

The PR appears safe to merge; MinIO is handled consistently through settings, connection validation, storage construction, and integration coverage.

No concrete blocking or independently actionable non-blocking defect remains after tracing the named provider through production configuration and synchronization paths.

Important Files Changed

Filename Overview
src/settings/settings.ts Adds MinIO consistently to provider parsing, options, endpoint derivation, signing-region handling, and completeness checks.
src/settings/tab.ts Adds reusable endpoint/region rendering and MinIO-specific field descriptions without changing draft or connection-test safeguards.
src/storage/storage.ts Extends required-field validation so MinIO follows the existing custom S3 endpoint and region path.
src/settings/settings.test.ts Covers MinIO persistence, endpoint normalization, provider visibility, and configuration completeness.
src/storage/storage.test.ts Covers missing and whitespace-only MinIO endpoint and region validation.
src/storage/storage.itest.ts Runs the existing real-server storage behavior through the named MinIO provider.
src/sync/sync.itest.ts Runs end-to-end synchronization against MinIO using the newly named provider.
docs/technical_settings.md Documents MinIO as a production provider with an explicit endpoint and signing region.

Reviews (1): Last reviewed commit: "feat: add MinIO as provider in settings ..." | Re-trigger Greptile

Context used:

@revett

revett commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@kwame-Owusu Nice work dude! Quick turn around on the issue

@revett
revett merged commit f79bf8b into 8thpark:main Aug 11, 2026
11 checks passed
@revett revett changed the title [#212 ] Settings → add MinIO as provider in settings and make it obvious [#212] Settings → add MinIO as provider in settings and make it obvious Aug 11, 2026
@revett revett changed the title [#212] Settings → add MinIO as provider in settings and make it obvious [#212] Settings → Add MinIO as provider in settings Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MinIO as provider within settings

2 participants