[#182] Sync → Say the things a status bar icon cannot - #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #182
Problem
Changes
notify, a pure module holding the single table that decides what Geode says and how long it stays, so every word and every silence is pinned by one testshowToaston the plugin, the only placeNoticeis now constructedsyncOnceto reportconflictCount, because a conflict copy is the one thing a successful pass does that nobody would find on their ownSyncReportfrom the finished pass rather than tracking it alongside, so there is one description of what happened instead of two that can driftWhy
Greptile Summary
This PR adds centralized user-facing sync notifications and reports conflict-copy counts from completed sync passes.
Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains.
No blocking failure remains.
Important Files Changed
Reviews (2): Last reviewed commit: "Address comments" | Re-trigger Greptile
Context used (3)