refactor/ Fix Shotgun Surgery and excessive Switch Statements Code Smells#95
Draft
yasmimdanntass wants to merge 1 commit into
Draft
refactor/ Fix Shotgun Surgery and excessive Switch Statements Code Smells#95yasmimdanntass wants to merge 1 commit into
yasmimdanntass wants to merge 1 commit into
Conversation
…ent code so it supports addons and new tiers addition more easily, avoiding Code Smells such as excessive Switch Statements and Shotgun Surgery.
Owner
|
Hi @yasmimdanntass , we've merged some changes that conflict with yours, so can't merge your PR at this time. If you wish to still have this merged, could you please resolve the conflicts? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the Chest Tiers management code so it supports addons and new tiers addition more easily, using an interface that defines a contract with the main methods a chest tier must have. (Obs.: This PR was created for academic purposes! I'm a big fan of Iron Chests and your work is just awesome!)