This repository was archived by the owner on May 11, 2021. It is now read-only.
Fix for IndexOutOfBoundsException - #595
Open
mariuszs wants to merge 1 commit into
Open
Conversation
| parameterValues = joinPoint.getArgs() != null ? asList(joinPoint.getArgs()) : emptyList(); | ||
| List<String> names = signature.getParameterNames() != null ? List.of(signature.getParameterNames()) : List.empty(); | ||
| List<Object> values = joinPoint.getArgs() != null ? List.of(joinPoint.getArgs()) : List.empty(); | ||
| parameters = HashMap.ofEntries(names.zip(values).map(t -> Tuple.of(t._1, t._2.toString()))); |
Collaborator
There was a problem hiding this comment.
Do we really need for that easy thing java slang ? :D
Contributor
There was a problem hiding this comment.
We can use java 8 Optional and slang is definitely not needed. Is the bug still valid?
me3x
suggested changes
Oct 23, 2017
me3x
left a comment
me3x
left a comment
Contributor
There was a problem hiding this comment.
Remove slang, use java optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@norbson Take a look