Claude/localfilestorage filename validation q wx gb#83
Merged
Conversation
LocalFileStorageService used Path.GetInvalidFileNameChars(), which on Linux returns only NUL and '/'. A filename like "danger:name?.webp" was left intact in the URL, so SaveBytesAsync_ShouldStripInvalidFilenameCharacters failed on the Linux CI runner. Replace with an allow-list regex that keeps only [A-Za-z0-9._-] — same behaviour on every host. Also add the blank lines flagged by MD032 (lists-around-blanks) in CHANGELOG.md so markdownlint-cli2 runs clean.
gitleaks v8 switched its regex engine to go-re2, which rejects
(?!...) at compile time. The five custom rules each used
(?!\$\{|%[A-Z_]) to skip env-var interpolations like ${VAR} / %VAR%,
panicking the binary on startup ("bad perl operator: (?!") and
short-circuiting the whole secret scan.
Strip the lookahead from every rule. The [allowlist].regexes block
already filters env-var interpolation patterns, so the false-positive
guard remains in place. Add a header comment noting the constraint
so future rules don't reintroduce a lookahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Related issue
Closes #
Testing
dotnet test Planora.sln)npm run lint && npm run type-check)npm run test)Checklist
.env.exampleupdated if new env vars were added## Unreleased