Introduce HeapSize() - #569
Open
ArthurBandaryk wants to merge 1 commit into
Open
Conversation
ArthurBandaryk
marked this pull request as draft
August 26, 2022 13:48
ArthurBandaryk
force-pushed
the
artur.heap-size
branch
from
August 29, 2022 15:33
680206d to
aee76a8
Compare
ArthurBandaryk
force-pushed
the
artur.heap-size
branch
2 times, most recently
from
August 31, 2022 15:42
a803f92 to
1833d73
Compare
ArthurBandaryk
marked this pull request as ready for review
August 31, 2022 15:46
ArthurBandaryk
force-pushed
the
artur.heap-size
branch
from
August 31, 2022 19:36
1833d73 to
3669e23
Compare
benh
requested changes
Sep 6, 2022
benh
left a comment
benh
left a comment
Member
There was a problem hiding this comment.
Instead of adding checks for heap size in every test, let's create some new tests to show that types that don't have any heap size equal zero but those that do are a value greater than zero.
ArthurBandaryk
force-pushed
the
artur.heap-size
branch
from
September 6, 2022 09:46
3669e23 to
4a2d85a
Compare
This PR adds the possibility to determine for a chain of eventuals the maximum amount of heap memory that needs to get allocated.
ArthurBandaryk
force-pushed
the
artur.heap-size
branch
from
September 7, 2022 12:54
4a2d85a to
2088439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to determine for a chain of
eventuals the maximum amount of heap memory that needs to
get allocated.