Fix legacy P2PKH singlesig address verification#373
Open
etherbiswas wants to merge 5 commits into
Open
Conversation
Author
|
@3rdIteration please Review |
Added detailed architecture flow diagrams and explanations for SeedSigner, including boot and runtime flow, main interaction loop, QR scan flow, PSBT signing flow, seed flow, and hardware flow.
Enhance README with architecture and flow diagrams
Author
|
Address verification currently also only had multisig support only, when singlesig was being used the resultant behavior was skipping, refer commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes legacy P2PKH address verification when verifying addresses derived from singlesig descriptors.
Previously,
get_multisig_address()only allowed legacy descriptors whendescriptor.is_basic_multisigwas true:This prevented valid legacy singlesig descriptors from being verified and resulted in the error:
The fix allows legacy descriptors to be derived regardless of whether they are multisig:
Testing
I reproduced the issue on a physical SeedSigner Pi0 Smartcard build using a Satochip card configured with legacy (P2PKH) addresses.
Before the change:
Address verification failed with:
p2pkh address verification not yet implemented!After the change:
Screenshots
No UI changes were made.
[ ] Raspberry Pi OS Manual Build
[x] SeedSigner OS on a Pi0/Pi0W board
[ ] Other
[x] Bug fix
[ ] New feature
[ ] Code refactor
[ ] Documentation
[ ] Other