Add conditional send to ByteSource trait - #3
Open
rlamarche wants to merge 1 commit into
Open
Conversation
rlamarche
force-pushed
the
feat/add-send
branch
from
August 20, 2026 19:17
0dba8ad to
6115c5b
Compare
supporting environments.
rlamarche
force-pushed
the
feat/add-send
branch
from
August 20, 2026 19:18
6115c5b to
4ea77cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace non send futures with conditional send futures in
ByteSourcetrait to be able to use this crate with a multi-threaded architecture.It also adds a
ConditionalSynctrait for the same reason (the trait have to be Sync to it's reference is send while wrapped in the future).It does not break compatibility with wasm.