Add GHCR CI and fix go-bindata build path#2
Merged
Merged
Conversation
The build installed go-bindata from github.com/kevinburke/go-bindata/go-bindata, a module path that no longer resolves (go get fails with "does not contain package"). This broke `make build` and therefore the Docker image build from source. Switch to `go install github.com/kevinburke/go-bindata/v4/go-bindata@v4.0.2`, which resolves and pins a known-good version. Verified by a clean `docker build` of the image. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GitHub Actions workflow that builds the Docker image and pushes it to ghcr.io/<owner>/subspace: - on push to master -> tags the image `master` and `latest` - on version tags (v*) -> semver tags - on pull requests -> builds only (no push) to verify the image compiles Multi-arch (linux/amd64, linux/arm64) via Buildx + QEMU, with GitHub Actions layer caching. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When PR #1 was merged, only the first commit (the user-management API) landed on
master. The other two commits from that branch were dropped, leavingmasterin a state where:.github/workflows/has no build workflow — the CI to build/push the image is missing.Makefilestill installsgo-bindatafromgithub.com/kevinburke/go-bindata/go-bindata, a module path that no longer resolves (go getfails with "does not contain package"). This breaksmake buildand therefore the Docker image build from source — and would also break the CI below.This PR re-applies those two changes.
Changes
go install github.com/kevinburke/go-bindata/v4/go-bindata@v4.0.2, which resolves and pins a known-good version. Verified with a cleandocker build..github/workflows/docker-build.yml) — builds the image with Buildx + QEMU (linux/amd64, linux/arm64) and pushes toghcr.io/<owner>/subspace:master→ tagsmaster+latestv*tags → semver tagsNotes