Post json fixes - #7
Merged
Merged
Conversation
check_yellow_children skipped any reply that made four for Yellow, which asks
nothing of the position. A Red move that simply loses was caught only when some
unrelated reply happened to be uncovered, and reported as that reply's problem.
Set branches["4265626642"] to "4", where Yellow threatens four in column 2, and
check 5 now fails with:
['4265626642', '4', '2', 'Yellow wins the game with this reply']
Before, it named column 4 instead, and would have said nothing at all had the
rest been covered.
The shipped solution passes all nine checks either way, which is why the
rewrite could drop this without the data noticing. Same gap as 94fc474.
A real Windows console handles the check marks the table uses, but stdout falls back to the locale's ANSI codepage as soon as it is anything else, and cp1252 has no code point for them. So `python solution/validate_solution.py`, the command CONTRIBUTING gives, ended in UnicodeEncodeError and exited 1 whenever it was piped, redirected, or run from Git Bash, after all nine checks had already passed.
Removing verify.yml left both remaining workflows triggered only by a push to main, and rebuild.yml is path-filtered to four paths that exclude validate_solution.py. Nothing ran on a pull request, and the checker itself was never checked from either direction. Hence both events: the recent history here is direct pushes rather than pull requests, and those need it as much. None of the conditional logic that made the old workflows worth simplifying comes back. Read-only permissions, no path filter, nothing to install since validate_solution.py is standard library only. The `shell: bash` line is load-bearing: without pipefail a failing check piped through tee reports success. The guide still described steady_states.txt, branches.txt and the 41->5 syntax, so anyone following it would edit files that no longer exist. It now shows both JSON shapes and writes claimeven as a space throughout, which check 0 now requires: the old advice to use a dot existed only because a trailing space is invisible and editors strip it, and a quoted JSON string cannot lose one. Two of its claims were also wrong. Unreachable entries are reported a frontier at a time rather than all at once, so pruning is iterative. And two playable miai do not tie, they cancel, and the next level decides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.