fix: sidebar full-page rerun for global settings#7
Merged
Conversation
…ed pure fn - Added _rerun_app() helper using st.rerun() (no scope) for global ops - Added _settings_changed() pure function to detect setting changes - apply_settings now clears stale current_route when any global setting changes - All 6 global-affecting sidebar operations (apply settings, runtime flags, memory flags, view unread, clear unread, force refresh) now use full-page rerun instead of fragment-scoped rerun - 12 new tests covering _settings_changed, source checks for rerun strategy, and current_route clearing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Problem: Sidebar
st.rerun(scope="fragment")only re-runs the sidebar fragment, leaving status bar and wechat panel stale after applying settings\n- Fix: Added_rerun_app()helper (st.rerun()without scope) for all 6 global-affecting operations\n- current_route clearing: When any global setting changes, stale route cache is cleared so status bar shows correct values\n- Pure function:_settings_changed()extracted and tested with 8 parameterized cases\n- 12 new tests: source checks + pure function tests