fix(p2p): make Client.Stop idempotent (#105)#106
Merged
Conversation
Finding #34. Stop() did close(c.quit) with no guard, so a double Stop (a defer plus an explicit shutdown, or two concurrent shutdown paths) panics with "close of closed channel". Guard the close with a sync.Once (stopOnce), mirroring syncOnce. Test: TestStopIsIdempotent calls Stop twice and asserts no panic. go test -race ./... green. Co-authored-by: Liran Cohen <liranlasvegas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes audit finding #34.
Stop()didclose(c.quit)with no guard (unlikesyncOncefor the synced channel), so a double Stop — adeferplus an explicit shutdown, or two concurrent shutdown paths — panics with "close of closed channel". Latent today, but a fragile contract for an exported lifecycle method.Fix
Guard the close with a
sync.Once(stopOnce), mirroringsyncOnce.TestStopIsIdempotentcallsStop()twice and asserts no panic.go test -race ./...green (26 packages).Post-Deploy Monitoring & Validation
No additional operational monitoring required: this only removes a latent panic on a redundant Stop; shutdown behavior is otherwise unchanged.Closes #105
🤖 Generated with Claude Code